Skip to content
This repository was archived by the owner on Jul 22, 2024. It is now read-only.

Check for available apps when opening a file#3352

Merged
bluemarvin merged 1 commit into
masterfrom
v11/downloads_open
May 19, 2020
Merged

Check for available apps when opening a file#3352
bluemarvin merged 1 commit into
masterfrom
v11/downloads_open

Conversation

@keianhzo

@keianhzo keianhzo commented May 8, 2020

Copy link
Copy Markdown
Contributor

Check for available apps when opening a file otherwise we just show that the file is unsupported. It's not easy to test because of the lack of utilities in most platforms at the moment. It can be tested with:

  • 3GP, TIFF in Oculus
  • 3GP in Pico

@keianhzo keianhzo self-assigned this May 8, 2020
@keianhzo keianhzo requested a review from bluemarvin May 8, 2020 14:49
@keianhzo keianhzo added this to the #11 polish milestone May 11, 2020
@bluemarvin

Copy link
Copy Markdown
Contributor

Looks like this depends on #3297 and needs to be rebased?

@bluemarvin

Copy link
Copy Markdown
Contributor

I wasn't able to ever get the built in app to play any of the video I downloaded on the Pico G2. Additionally, all video's I downloaded from https://www.appsloveworld.com/download-sample-3gp-video-file-for-testing/ failed to download yet the download works on desktop. Downloaded videos that didn't play were from https://filesamples.com/formats/3gp

@keianhzo keianhzo force-pushed the v11/downloads_open branch from 1b44db9 to db3bea2 Compare May 18, 2020 13:00
@keianhzo

Copy link
Copy Markdown
Contributor Author

@bluemarvin Fixed rebase issues.

Regarding the system app playback errors, I think there not much we can do about it other than never allowing to open with an external app.

The download failure, the Android DownloadManager fails with Stop requested with status TOO_MANY_REDIRECTS: Too many redirects but I couldn't find much info about it, might be system limitation.

@bluemarvin bluemarvin merged commit 4abe405 into master May 19, 2020
@bluemarvin bluemarvin deleted the v11/downloads_open branch May 19, 2020 20:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants